[libvirt] [PATCH v4 6/6] qemu-command: introduce new vgamem attribute for QXL video device

Giuseppe Scrivano gscrivan at redhat.com
Mon Dec 1 15:09:44 UTC 2014


Pavel Hrdina <phrdina at redhat.com> writes:

> Well, I think that this is not correct usage of the libvirt XML. You
> should not just change one part of the device configuration. If user of
> virt-manager change the device type, you should create a new XML
> according to the new device type and copy all valid values and then drop
> the original XML configuration.
>
> I don't think that just silently remove unsupported configuration is
> appropriate solution. Even if we will print warning that it's not
> supported and it will be removed I still don't like it.

ok thanks to have confirmed it.  I'll fix it in virt-manager.

Regards,
Giuseppe




More information about the libvir-list mailing list