[libvirt] [PATCH] qemu: add tun devices to cgroup ACL

[Daniel P. Berrange]

On Thu, Nov 27, 2014 at 01:42:01PM +0800, rongqing.li at windriver.com wrote:
> From: Roy Li <rongqing.li at windriver.com>
> 
> When systemd is used as init, CGroup will be enabled by default, and
> lead to virsh unable to start VM(which is using the tun/tap), since
> virsh can not access /dev/net/tun device
> 
> Signed-off-by: Roy Li <rongqing.li at windriver.com>
> ---
>  src/qemu/qemu.conf                 | 3 ++-
>  src/qemu/qemu_cgroup.c             | 2 +-
>  src/qemu/test_libvirtd_qemu.aug.in | 1 +
>  3 files changed, 4 insertions(+), 2 deletions(-)

NACK, libvirt should create all TUN devices, except in the case
of <interface type=ethernet> which is a deprecated/discouraged
option as it is insecure to allow QEMU to create TUN devices
itself.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|