[libvirt] [PATCHv2 9/9] lxc: always use virDomainNetGetActualBridgeName to get interface's bridge

John Ferlan jferlan at redhat.com
Tue Dec 2 22:13:27 UTC 2014



On 12/02/2014 12:08 PM, Laine Stump wrote:
> qemuNetworkIfaceConnect() used to have a special case for
> actualType='network' (a network with forward mode of route, nat, or
> isolated) to call the libvirt public API to retrieve the bridge being
> used by a network. That is no longer necessary - since all network
> types that use a bridge and tap device now get the bridge name stored
> in the ActualNetDef, we can just always use
> virDomainNetGetActualBridgeName() instead.

I think you need to adjust the commit message to be lxc centric - this
looks to be a copy of .8's commit message...

> ---
> Change from V1: This can now actually be applied with no ill side
> effects, due to Patch 4/9 setting actual.brname during a libvirtd
> restart)
> 
>  src/lxc/lxc_driver.c  | 32 ++------------------------------
>  src/lxc/lxc_process.c | 32 +-------------------------------
>  2 files changed, 3 insertions(+), 61 deletions(-)
> 

Same note as .8 w/ regard to applying this...

ACK with the commit message adjustment,

John

BTW: I ran everything through my Coverity build and that didn't find any
lingering or dangling issues...




More information about the libvir-list mailing list