[libvirt] [PATCH] qemu: Auto generate a controller when attach hostdev and chr device

[Michal Privoznik]

On 15.12.2014 10:49, Luyao Huang wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1174154
>
> When we use attach-device add a hostdev or chr device which have a
> iscsi address or others (just like guest agent, subsys iscsi disk...),
> we will find there is no basic controller for our new attached device.
> Somtimes this will make guest cannot start after we add them (although
> they can start at the second time).
>
> Signed-off-by: Luyao Huang <lhuang at redhat.com>
> ---
>   src/qemu/qemu_driver.c | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index df3ba6d..62fb784 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -7250,6 +7250,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps,
>           if (virDomainHostdevInsert(vmdef, hostdev))
>               return -1;
>           dev->data.hostdev = NULL;
> +        if (virDomainDefAddImplicitControllers(vmdef) < 0)
> +            return -1;
>           if (qemuDomainAssignAddresses(vmdef, qemuCaps, NULL) < 0)
>               return -1;
>           break;
> @@ -7290,6 +7292,8 @@ qemuDomainAttachDeviceConfig(virQEMUCapsPtr qemuCaps,
>           if (qemuDomainChrInsert(vmdef, dev->data.chr) < 0)
>               return -1;
>           dev->data.chr = NULL;
> +        if (virDomainDefAddImplicitControllers(vmdef) < 0)
> +            return -1;
>           break;
>
>       case VIR_DOMAIN_DEVICE_FS:
>

ACKed and pushed.

Michal