[libvirt] [PATCH 2/3] qemu: Free saved error in qemuDomainSetVcpusFlags

Martin Kletzander mkletzan at redhat.com
Tue Dec 16 19:13:54 UTC 2014


Commit e3435caf added cleanup code to qemuDomainSetVcpusFlags() that was
not supposed to reset the error.  Usual procedure was done, saving the
error to temporary variable, but it was never free'd, but rather leaked.

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 src/qemu/qemu_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 7211d42..9aba4c8 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4781,6 +4781,7 @@ qemuDomainSetVcpusFlags(virDomainPtr dom, unsigned int nvcpus,
         err = virSaveLastError();
         virCgroupSetCpusetMems(cgroup_temp, mem_mask);
         virSetError(err);
+        virFreeError(err);
     }

     if (!qemuDomainObjEndJob(driver, vm))
-- 
2.2.0




More information about the libvir-list mailing list