[libvirt] [PATCH 0/2] ESX: Implement virDomainScreenshot

[Matthias Bolte]

2014-03-27 23:24 GMT+01:00 Dawid Zamirski <dzamirski at dattobackup.com>:
> Hello,
>
> The following patches implement virDomainScreenshot for the ESX driver.
> The screenshot VI API call was added in version 4.0, therefore, I had to
> make changes to esx_vi_generator.py in order to allow VI method calls for
> versions newer than 2.5. This was done by adding an optional "apiVersion"
> token to the method header definition in the .input file. If it is not
> specified, "2.5" will be used so existing VI calls will work "as is"
> without any code updates.

Hi,

let me start this with saying sorry... I basically had a working
virDomainScreenshot implementation for ESX sitting on my harddrive for
2 years by now, but I never managed to post it for review.

I posted it now [1]. As I mentioned in the other thread I think your
implementation has two disadvantages: using a temporary file and
requiring ESX 4.0. Actually the 4.0 requirement is not that bad, as
4.0 is already somewhat old again, but if it can be avoid I'd like to
do that.

But I like the way you handled the SOAPAction header problem and will
review that in more detail.

[1] https://www.redhat.com/archives/libvir-list/2014-March/msg01915.html

-- 
Matthias Bolte
http://photron.blogspot.com