[libvirt] [PATCH 7/n] conf: move storage secret type to util/

Peter Krempa pkrempa at redhat.com
Mon Mar 31 07:41:47 UTC 2014


On 03/28/14 16:01, Eric Blake wrote:
> This one is a relatively easy move.  We don't ever convert the
> enum to or from strings (it is inferred from other elements in
> the xml, rather than directly represented).
> 
> * src/conf/domain_conf.h (virDomainDiskSecretType): Move...
> * src/util/virstoragefile.h (virStorageSecreteType): ...and
> rename.
> * src/conf/domain_conf.c (virDomainDiskSecretType): Drop unused
> enum conversion.
> (virDomainDiskAuthClear, virDomainDiskDefParseXML)
> (virDomainDiskDefFormat): Adjust clients.
> * src/qemu/qemu_command.c (qemuGetSecretString): Likewise.
> * src/qemu/qemu_conf.c (qemuTranslateDiskSourcePoolAuth):
> Likewise.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  src/conf/domain_conf.c    | 19 +++++++------------
>  src/conf/domain_conf.h    | 10 +---------
>  src/qemu/qemu_command.c   |  8 ++++----
>  src/qemu/qemu_conf.c      |  8 ++++----
>  src/util/virstoragefile.h |  9 +++++++++
>  5 files changed, 25 insertions(+), 29 deletions(-)
> 

ACK

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140331/7e115c27/attachment-0001.sig>


More information about the libvir-list mailing list