[libvirt] [PATCH v2 2/2] qemu: qemuOpenFileAs - set flag VIR_FILE_OPEN_FORCE_MODE
Michal Privoznik
mprivozn at redhat.com
Mon Feb 9 14:20:34 UTC 2015
On 30.01.2015 18:52, John Ferlan wrote:
> In the event we're falling into the code that tries to create the file
> in a forked environment (VIR_FILE_OPEN_FORK) we pass different mode bits,
> but those are never set because the virFileOpenForceOwnerMode has a check
> if the OPEN_FORCE_MODE bit is set before attempting to change the mode.
>
> Since this is a special case it seems reasonable to set u+rw,g+rw,o
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/qemu/qemu_driver.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 59a9593..892d804 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -2965,6 +2965,9 @@ qemuOpenFileAs(uid_t fallback_uid, gid_t fallback_gid,
>
> /* Retry creating the file as qemu user */
>
> + /* Since we're passing different modes... */
> + vfoflags |= VIR_FILE_OPEN_FORCE_MODE;
> +
> if ((fd = virFileOpenAs(path, oflags,
> S_IRUSR|S_IWUSR|S_IRGRP|S_IWGRP,
> fallback_uid, fallback_gid,
>
ACK
Michal
More information about the libvir-list
mailing list