[libvirt] [PATCH 02/12] domain: separate out function for post parse timer validation

[Peter Krempa]

On Thu, Jan 07, 2016 at 22:49:56 -0500, Cole Robinson wrote:
> This should be a no-op
> ---
>  src/conf/domain_conf.c | 53 +++++++++++++++++++++++++++++---------------------
>  1 file changed, 31 insertions(+), 22 deletions(-)
> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index ab22322..2570f94 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c

[...]

> @@ -3845,6 +3824,36 @@ virDomainDefPostParseInternal(virDomainDefPtr def,
>          }
>      }
>  
> +    return 0;
> +}

Two newlines please

> +
> +static int
> +virDomainDefPostParseInternal(virDomainDefPtr def,
> +                              virCapsPtr caps ATTRIBUTE_UNUSED,
> +                              unsigned int parseFlags)
> +{
> +    /* verify init path for container based domains */
> +    if (def->os.type == VIR_DOMAIN_OSTYPE_EXE && !def->os.init) {
> +        virReportError(VIR_ERR_XML_ERROR, "%s",
> +                       _("init binary must be specified"));
> +        return -1;

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160108/bee7d87a/attachment-0001.sig>