[libvirt] [PATCH 2/4] qemu: cold-unplug of watchdog

Michal Privoznik mprivozn at redhat.com
Tue Sep 12 14:03:20 UTC 2017


On 09/12/2017 03:31 PM, John Ferlan wrote:
> 
> 
> On 09/05/2017 07:45 AM, Michal Privoznik wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1447169
>>
>> Again, no special here.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>  src/libvirt_private.syms |  1 +
>>  src/qemu/qemu_driver.c   | 11 ++++++++++-
>>  2 files changed, 11 insertions(+), 1 deletion(-)
>>
> 
> Is there a specific reason to separate this from patch 1. I would think
> attach and detach would be something added at the same time. OTOH, IDC
> since the end result is still achieved.

Yeah, they can be merged, they can be separated. Since I'm separating
live attach & detach (due to their complexity) I've separated these two
too (for consistency).

> 
> Reviewed-by: John Ferlan <jferlan at redhat.com>

Pushed. Thanks.

Michal




More information about the libvir-list mailing list