[libvirt] [PATCH v2 2/2] qemu: Figure out nodeset bitmap size correctly

Ján Tomko jtomko at redhat.com
Thu Apr 19 15:18:24 UTC 2018


On Thu, Apr 19, 2018 at 04:19:39PM +0200, Andrea Bolognani wrote:
>The current private XML parsing code relies on the assumption
>that NUMA node IDs start from 0 and are densely allocated,
>neither of which is necessarily the case.
>
>Change it so that the bitmap size is dynamically calculated by
>looking at NUMA node IDs instead, which ensures all nodes will
>be able to fit and thus the bitmap will be parsed successfully.
>
>Update one of the test cases so that it would fail with the
>previous approach, but passes with the new one.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1490158
>Signed-off-by: Andrea Bolognani <abologna at redhat.com>
>---
> src/qemu/qemu_domain.c                    | 10 +++++++++-
> tests/qemustatusxml2xmldata/modern-in.xml |  2 +-
> 2 files changed, 10 insertions(+), 2 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180419/628bf9f3/attachment-0001.sig>


More information about the libvir-list mailing list