[libvirt] [PATCH 29/29] Require space after cast

[Ján Tomko]

On Mon, Apr 23, 2018 at 02:44:57PM +0200, Martin Kletzander wrote:
>Let's make a rule out of it and document it.  This is based on few sources:
>
>1) Most of the code [1] used spaces after casts, so the patch to change it this
>   way rather than the other way around is smaller
>

Just because it's popular does not mean it's right.

>2) I asked the first libvirt developer on my left when deciding, they preferred
>   spaces

Selection bias.

>
>3) My own preference.
>

De gustibus non est disputandum.

>4) The fact that this is clearly the superior way of casting =D
>

[citation needed]

>[1] 54.85% is more than 50%, plus it is increasing as it was 52.96% during the
>    first draft of this clean-up.
>
>Signed-off-by: Martin Kletzander <mkletzan at redhat.com>

ACK if you forbid spaces after casts instead.

Jano

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180423/204fda8f/attachment-0001.sig>