[libvirt] [PATCH 05/14] driver: fix handling of error return from finding resource

Michal Privoznik mprivozn at redhat.com
Tue Apr 24 12:16:56 UTC 2018


On 04/19/2018 07:09 PM, Daniel P. Berrangé wrote:
> The virFileFindResource method merely builds up the expected fully
> qualified path to the resource. It does not actually check if it exists
> on disk. The loadable module callers were mistakenly thinking a NULL
> indicates the file doesn't exist on disk, whereas it in fact indicates
> an out of memory error.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  src/driver.c                  | 2 +-
>  src/storage/storage_backend.c | 2 +-
>  src/util/virfile.c            | 4 ++++
>  3 files changed, 6 insertions(+), 2 deletions(-)

ACK

Michal




More information about the libvir-list mailing list