[libvirt] [dbus PATCH 00/15] Build system fixes, cleanups and tweaks

Pavel Hrdina phrdina at redhat.com
Mon Jul 2 08:11:46 UTC 2018


On Fri, Jun 29, 2018 at 06:01:07PM +0200, Andrea Bolognani wrote:
> It all started when I got
> 
>   tests/Makefile.am:17: warning: source file '$(top_srcdir)/src/util.c' is in a subdirectory,
>   tests/Makefile.am:17: but option 'subdir-objects' is disabled
>   automake: warning: possible forward-incompatibility.
>   automake: At least a source file is in a subdirectory, but the 'subdir-objects'
>   automake: automake option hasn't been enabled.  For now, the corresponding output
>   automake: object file(s) will be placed in the top-level directory.  However,
>   automake: this behaviour will change in future Automake versions: they will
>   automake: unconditionally cause object files to be placed in the same subdirectory
>   automake: of the corresponding sources.
>   automake: You are advised to start using 'subdir-objects' option throughout your
>   automake: project, to avoid future incompatibilities.
> 
> when running autogen.sh and decided to investigate; before
> I realized it, I was already deep down the rabbit hole and
> falling towards Wonderland at an increasingly concerning
> speed.
> 
> Andrea Bolognani (15):
>   gitignore: Fix man page pattern
>   gitignore: Fix aclocal.m4 pattern
>   tests: Don't distribute compiled binaries
>   src: Fix typo in PIE_LDFLAGS
>   src: Remove empty CLEANFILES
>   src: Don't list source files in EXTRA_DIST
>   tests: Move includes to AM_CPPFLAGS
>   src: Make CFLAGS and LDFLAGS global
>   configure: Enable libtool
>   src: Build libutil.la separately
>   configure: Enable subdir-objects
>   configure: Enable -Wno-obsolete and tar-pax
>   configure: Use xz for release archives
>   data: Rename some variables to *_in_files
>   autotools: Use consistent style

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180702/55655438/attachment-0001.sig>


More information about the libvir-list mailing list