[libvirt] [PATCH] qemu:Fix snapshot creating with vm xml persistent

Peter Krempa pkrempa at redhat.com
Mon Jul 30 07:45:04 UTC 2018


On Thu, Jul 26, 2018 at 03:03:04 -0400, Bobo Du wrote:
> it is a bug when the vm is undefined after started.
> blockcommit interface also has the bug with above.

Could you please specify steps and the outcome when this breaks?

vm->newDef should not be present if the VM is not persistent so the code
below should be correct as is now. I think there might be some other
bug.

> 
> Signed-off-by: Bobo Du <dubobo at didichuxing.com

Missing closing angle bracket. Please use the '-s' switch for git commit
which will add the signoff line in the correct format.

> ---
>  src/qemu/qemu_blockjob.c | 2 +-
>  src/qemu/qemu_driver.c   | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20180730/0c368ce5/attachment-0001.sig>


More information about the libvir-list mailing list