[libvirt] [PATCH] virresctrl: remove bogus virResetLastError

Ján Tomko jtomko at redhat.com
Fri Oct 5 14:42:07 UTC 2018


virFileReadValueUint does not log errors for non-existient files,
it merely returns -2.

Commit 12093f1 introduced this.

Signed-off-by: Ján Tomko <jtomko at redhat.com>
---
 src/util/virresctrl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/util/virresctrl.c b/src/util/virresctrl.c
index fb25ca84f0..df5b5124e6 100644
--- a/src/util/virresctrl.c
+++ b/src/util/virresctrl.c
@@ -638,7 +638,6 @@ virResctrlGetMonitorInfo(virResctrlInfoPtr resctrl)
         VIR_INFO("The file '" SYSFS_RESCTRL_PATH "/info/L3_MON/num_rmids' "
                  "does not exist");
         ret = 0;
-        virResetLastError();
         goto cleanup;
     } else if (rv < 0) {
         /* Other failures are fatal, so just quit */
@@ -653,7 +652,6 @@ virResctrlGetMonitorInfo(virResctrlInfoPtr resctrl)
          * will not exist. */
         VIR_DEBUG("File '" SYSFS_RESCTRL_PATH
                   "/info/L3_MON/max_threshold_occupancy' does not exist");
-        virResetLastError();
     } else if (rv < 0) {
         goto cleanup;
     }
-- 
2.16.4




More information about the libvir-list mailing list