[libvirt] [snmp PATCH 00/20] Misc cleanups and improvements

[Martin Kletzander]

On Thu, Oct 18, 2018 at 02:26:38PM +0200, Michal Privoznik wrote:
>These are not pushed. I'll wait couple of moments if there is somebody
>who has opinion. If not I will push them.
>

Except the libvirt-snmp internals this looks good.  Few nits posted for
particular patches, really just nits.

It's a nice clean-up, it definitely makes sense to drop support for too old
libvirt IMHO.

If you want to make the (+)/(-) ratio even smaller you can reorganize some ofthe
patches about error printing and formatting as you are adding some support, then
moving it, then putting it in another function and so on.  But I don't think the
readability is too much impacted by that.  It would just make for a nicer git
history and even more awesome ratio ;)

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20181019/0fb4eeda/attachment-0001.sig>