[libvirt] [PATCH 2/2] qemu: blockcopy: Fix conditions when virStorageSource should be initialized

[Ján Tomko]

On Fri, Nov 29, 2019 at 02:44:00PM +0100, Peter Krempa wrote:
>Commit 4b58fdf280a which enabled block copy also for network
>destinations needed to limit when the 'mirror' storage source is
>initialized in cases when we e.g. don't have an appropriate backend.
>
>Limiting it just to virStorageFileSupportsCreate is too restrictive as
>for example we can't precreate block devices and thus wouldn't
>initialize the 'mirror' but since it's a local source we'd try to
>examine it. This would fail since it wouldn't be initialized.
>
>Fix it by introducing a more granular check whether certain operations
>are supported and fix the check interlocks.
>
>https://bugzilla.redhat.com/show_bug.cgi?id=1778058
>
>Signed-off-by: Peter Krempa <pkrempa at redhat.com>
>---
> src/qemu/qemu_driver.c | 19 ++++++++++++-------
> 1 file changed, 12 insertions(+), 7 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20191202/3485058a/attachment-0001.sig>