[libvirt] [PATCH v2 17/25] tests: qemustatusxml2xml: Add test for 'pull' type backup job

Eric Blake eblake at redhat.com
Wed Dec 4 22:03:28 UTC 2019


On 12/3/19 11:17 AM, Peter Krempa wrote:
> Signed-off-by: Peter Krempa <pkrempa at redhat.com>
> ---
>   .../qemustatusxml2xmldata/backup-pull-in.xml  | 608 ++++++++++++++++++
>   .../qemustatusxml2xmldata/backup-pull-out.xml |   1 +
>   tests/qemuxml2xmltest.c                       |   2 +
>   3 files changed, 611 insertions(+)
>   create mode 100644 tests/qemustatusxml2xmldata/backup-pull-in.xml
>   create mode 120000 tests/qemustatusxml2xmldata/backup-pull-out.xml

Reviewed-by: Eric Blake <eblake at redhat.com>

> +++ b/tests/qemustatusxml2xmldata/backup-pull-out.xml
> @@ -0,0 +1 @@
> +backup-pull-in.xml
> \ No newline at end of file

Odd that diff warns about this (empty files are an exception to the rule 
that a text file must end in a newline).  But harmless to the patch itself.

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org




More information about the libvir-list mailing list