[libvirt] [PATCH 2/5] testutilsxen: Avoid double free of driver caps

Michal Privoznik mprivozn at redhat.com
Wed Dec 18 08:37:05 UTC 2019


In testXLInitDriver() a dummy driver structure is filled and it
is freed later in testXLFreeDriver(). However, it is sufficient
to unref just driver->config because that results in
libxlDriverConfigDispose() being called which unrefs
driver->config->caps. There is no need to unref it again in
testXLFreeDriver() - in fact it's undesired.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/testutilsxen.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tests/testutilsxen.c b/tests/testutilsxen.c
index 75cd42ec43..b73c79581d 100644
--- a/tests/testutilsxen.c
+++ b/tests/testutilsxen.c
@@ -105,7 +105,6 @@ libxlDriverPrivatePtr testXLInitDriver(void)
 
 void testXLFreeDriver(libxlDriverPrivatePtr driver)
 {
-    virObjectUnref(driver->config->caps);
     virObjectUnref(driver->config);
     virObjectUnref(driver->xmlopt);
     virMutexDestroy(&driver->lock);
-- 
2.24.1




More information about the libvir-list mailing list