[libvirt] [PATCH v2 11/25] conf: Add <disk model='virtio-{non-}transitional'/>

Cole Robinson crobinso at redhat.com
Wed Feb 6 16:25:27 UTC 2019


On 1/31/19 11:03 AM, Andrea Bolognani wrote:
> On Wed, 2019-01-30 at 16:00 +0100, Pavel Hrdina wrote:
>> On Wed, Jan 23, 2019 at 04:32:39PM -0500, Cole Robinson wrote:
> [...]
>>> +          <dt><code>model</code></dt>
>>> +            <dd>
>>> +            Indicates the emulated device model of the disk. Typically
>>> +            this is indicated solely by the <code>bus</code> property but
>>> +            for <code>bus</code> "virtio" the model can be specified further
>>> +            with "virtio-transitional", "virtio-non-transitional", or
>>> +            "virtio" which matches the old behavior. These settings are
>>> +            only applicable when using controller bus type "pci".
>>> +            <span class="since">Since 5.1.0</span>
>>> +            </dd>
>>
>> It would be probably good idea to explain this a little bit more and
>> possibly add a reference/link to virtio specification.
> 
> Yeah, that sounds like a very good idea. We will probably want to
> make it its own section, too, so that we can link to it from each
> of the devices that support (non-)transitional VirtIO.
> 

Okay i'll add that in its own series. Having a separate section is a 
nice idea to reduce duplication

Thanks,
Cole




More information about the libvir-list mailing list