[libvirt] [PATCH] virsh: fix snapshot list --parent
Eric Blake
eblake at redhat.com
Thu Feb 14 15:30:54 UTC 2019
On 2/14/19 7:48 AM, Ján Tomko wrote:
> The root snapshot does not have a parent.
> Use NULLSTR_EMPTY to pass an empty string instead of putting
> too few columns in the table.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1662849
>
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
> tools/virsh-snapshot.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake at redhat.com>
>
> diff --git a/tools/virsh-snapshot.c b/tools/virsh-snapshot.c
> index 90000ef1aa..6cadb2b0d6 100644
> --- a/tools/virsh-snapshot.c
> +++ b/tools/virsh-snapshot.c
> @@ -1608,7 +1608,8 @@ cmdSnapshotList(vshControl *ctl, const vshCmd *cmd)
> &time_info);
>
> if (parent) {
> - if (vshTableRowAppend(table, snap_name, timestr, state, parent_snap,
> + if (vshTableRowAppend(table, snap_name, timestr, state,
> + NULLSTR_EMPTY(parent_snap),
> NULL) < 0)
> goto cleanup;
> } else {
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20190214/81a03d68/attachment-0001.sig>
More information about the libvir-list
mailing list