[libvirt] [jenkins-ci PATCH v5 1/5] lcitool: use subparsers for commands

[Daniel P. Berrangé]

On Tue, Feb 26, 2019 at 12:25:12PM +0100, Andrea Bolognani wrote:
> On Tue, 2019-02-26 at 11:00 +0000, Daniel P. Berrangé wrote:
> > +++ b/guests/README.markdown
> [...]
> > @@ -58,7 +58,7 @@ You can add more git repositories by tweaking the `git_urls` dictionary
> >  defined in `playbooks/build/jobs/defaults.yml` and then build arbitrary
> >  branches out of those with
> >  
> > -    lcitool -a build -h all -p libvirt -g github/cool-feature
> > +    lcitool build -g github/cool-feature all libvirt
> >  
> >  
> >  Host setup
> 
> You forgot to update the line
> 
>   0 0 * * * ~/libvirt-jenkins-ci/guests/lcitool -a update -h all -p all
> 
> in this section of the document. With that fixed,
> 
>   Reviewed-by: Andrea Bolognani <abologna at redhat.com>
> 
> 
> I'm not sure why you decided to post v5 before I got around to review
> the remaining two patches, but since you have R-b's for these first
> three patches now and they make sense even on their own, feel free to
> push them without waiting any further.

I didn't see any point in delaying these patches since they are
useful regardless of the cross-arch stuff, so it was easy to just
repost with those updates since you hadn't done the other reviews
yesterday.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|