[libvirt] [PATCH] virhostdev: Don't unref @pcidevs twice

Michal Privoznik mprivozn at redhat.com
Mon Sep 9 14:38:43 UTC 2019


In f08e6883cb4 I've made @pcidevs in
virHostdevReAttachPCIDevices() to be automatically unrefed using
VIR_AUTOUNREF() but I forgot to remove the line that explicitly
unrefs the object at the end of the function.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---

Pushed as trivial.

 src/util/virhostdev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/util/virhostdev.c b/src/util/virhostdev.c
index d710193b94..41fcab7222 100644
--- a/src/util/virhostdev.c
+++ b/src/util/virhostdev.c
@@ -1091,7 +1091,6 @@ virHostdevReAttachPCIDevices(virHostdevManagerPtr mgr,
 
     virObjectUnlock(mgr->activePCIHostdevs);
     virObjectUnlock(mgr->inactivePCIHostdevs);
-    virObjectUnref(pcidevs);
 }
 
 int
-- 
2.21.0




More information about the libvir-list mailing list