[PATCH v2 3/6] Revert "domain_conf.c: auto-align pSeries NVDIMM in virDomainMemoryDefPostParse()"

[Andrea Bolognani]

On Wed, 2020-11-18 at 16:58 -0300, Daniel Henrique Barboza wrote:
> The code to align ppc64 NVDIMMs on post parse was introduced in
> commit d3f3c2c97f9b. That commit failed to realize that we
> can't align memory unconditionally. As of commit c7d7ba85a624
> ("qemu: command: Align memory sizes only on fresh starts"),
> all memory alignment should be executed only when we're not
> migrating or in a snapshot.
> 
> This revert does not break any guests in the wild, given that
> ppc64 NVDIMMs are still being aligned in qemuDomainAlignMemorySizes().
> 
> Next patch will introduce a mechanism where we can have post
> parse NVDIMM alignment for pSeries without breaking the
> intended design, as defined by c7d7ba85a624.
> 
> This reverts commit d3f3c2c97f9b92c982ff809479495f44614edb88.
> 
> Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>
> ---
>  src/conf/domain_conf.c                        | 23 +------------------
>  .../memory-hotplug-nvdimm-ppc64.xml           |  2 +-
>  2 files changed, 2 insertions(+), 23 deletions(-)

I think it would make sense to also revert

  commit ace5931553c87beebb6b3cd994061742b3f88238
  Author: Daniel Henrique Barboza <danielhb413 at gmail.com>
  Date:   Mon Sep 14 22:02:47 2020 -0300

    conf, qemu: move qemuDomainNVDimmAlignSizePseries to domain_conf.c
    
    We'll use the auto-alignment function during parse time, in
    domain_conf.c. Let's move the function to that file, renaming
    it to virDomainNVDimmAlignSizePseries(). This will also make it
    clearer that, although QEMU is the only driver that currently
    supports it, pSeries NVDIMM restrictions aren't tied to QEMU.
    
    Reviewed-by: Andrea Bolognani <abologna at redhat.com>
    Signed-off-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

at the same time: as of this commit, there are no longer any callers
for virDomainNVDimmAlignSizePseries() outside of the QEMU driver.

-- 
Andrea Bolognani / Red Hat / Virtualization