[libvirt] [PATCH 0/7] Remove the last "no_memory" label

Fabiano Fidêncio fidencio at redhat.com
Thu Jan 2 13:57:51 UTC 2020


This series touches virfirewall.c, the last place where a no_memory
label can be found.

The series:
- Renames no_memory to cleanup;
- Gets rid of ENOMEM error treatment;
- Use g_auto / g_autofree in a few different places;
- Add new macros as ADD_ARG heavily rely on a goto;
- Remove no_memory mention from the hacking guide;

I'm not totally sure whether the new macros addition are worth it.

Fabiano Fidêncio (7):
  util: Rename 'no_memory' label to 'cleanup'
  util: Don't set/check for ENOMEM as a firewall error
  util: Use g_auto/g_autofree in virFirewallAddRuleFullV()
  util: Use g_auto in virFirewallStartTransaction()
  util: Add ADD_ARG_RETURN_ON_ERROR
  util: Add ADD_ARG_RETURN_VALUE_ON_ERROR
  docs: Remove mention to no_memory label

 docs/hacking.html.in   |  1 -
 src/util/virfirewall.c | 94 +++++++++++++++++++-----------------------
 2 files changed, 42 insertions(+), 53 deletions(-)

-- 
2.24.1




More information about the libvir-list mailing list