[libvirt] [PATCH 09/12] src: replace verify(expr) with G_STATIC_ASSERT(expr)

Pavel Hrdina phrdina at redhat.com
Tue Jan 14 15:00:58 UTC 2020


On Fri, Jan 10, 2020 at 03:41:13PM +0000, Daniel P. Berrangé wrote:
> G_STATIC_ASSERT() is a drop-in functional equivalent of
> the GNULIB verify() macro.
> 
> Signed-off-by: Daniel P. Berrangé <berrange at redhat.com>
> ---
>  build-aux/syntax-check.mk             |  6 ------
>  src/conf/snapshot_conf.h              |  2 +-
>  src/conf/virdomaincheckpointobjlist.c |  8 ++++----
>  src/esx/esx_network_driver.c          |  2 +-
>  src/esx/esx_storage_backend_iscsi.c   |  2 +-
>  src/esx/esx_storage_backend_vmfs.c    |  2 +-
>  src/internal.h                        |  1 -
>  src/libxl/xen_xm.c                    |  3 +--
>  src/nwfilter/nwfilter_dhcpsnoop.c     |  4 ++--
>  src/qemu/qemu_blockjob.h              |  4 ++--
>  src/qemu/qemu_capabilities.c          |  2 +-
>  src/qemu/qemu_driver.c                |  2 +-
>  src/qemu/qemu_firmware.h              |  2 +-
>  src/qemu/qemu_migration_params.c      |  2 +-
>  src/remote/remote_daemon_dispatch.c   | 10 +++++-----
>  src/util/virarch.c                    |  3 +--
>  src/util/vircgroup.h                  |  2 +-
>  src/util/vircrypto.c                  |  2 +-
>  src/util/virenum.h                    |  8 ++++----
>  src/util/virinitctl.c                 |  4 ++--
>  src/util/virkeycode.c                 | 22 +++++++++++-----------
>  src/util/virmacaddr.h                 |  2 +-
>  src/util/virobject.h                  |  8 ++++----
>  src/util/virperf.c                    |  2 +-
>  src/util/virstoragefile.c             |  4 ++--
>  src/util/virtypedparam.h              |  2 +-
>  src/util/virutil.c                    |  3 +--
>  src/vz/vz_driver.c                    |  2 +-
>  tests/virstringtest.c                 |  7 +++----
>  tools/virsh-domain.c                  |  2 +-
>  tools/virsh-network.c                 |  2 +-
>  tools/virsh-nodedev.c                 |  2 +-
>  tools/virsh-pool.c                    |  2 +-
>  tools/virsh-secret.c                  |  2 +-
>  tools/virt-host-validate-common.c     |  4 ++--
>  35 files changed, 63 insertions(+), 74 deletions(-)

I would also rename verify to G_STATIC_ASSERT in
examples/c/misc/event-test.c to match G_N_ELEMENTS, but this can
be done as a followup.

Reviewed-by: Pavel Hrdina <phrdina at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20200114/44775df4/attachment-0001.sig>


More information about the libvir-list mailing list