[PATCH 1/6] apparmor: Fix parthelper, iohelper and virt-aa-helper paths in profiles

[Jamie Strandboge]

On Sat, 25 Jan 2020, Michal Privoznik wrote:

> These helper binaries are installed under libexec dir not lib
> dir.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/security/apparmor/usr.lib.libvirt.virt-aa-helper | 2 +-
>  src/security/apparmor/usr.sbin.libvirtd              | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/security/apparmor/usr.lib.libvirt.virt-aa-helper b/src/security/apparmor/usr.lib.libvirt.virt-aa-helper
> index 11e9c039ca..504c70e0ce 100644
> --- a/src/security/apparmor/usr.lib.libvirt.virt-aa-helper
> +++ b/src/security/apparmor/usr.lib.libvirt.virt-aa-helper
> @@ -39,7 +39,7 @@ profile virt-aa-helper /usr/{lib,lib64}/libvirt/virt-aa-helper {
>    deny /dev/mapper/ r,
>    deny /dev/mapper/* r,
>  
> -  /usr/{lib,lib64}/libvirt/virt-aa-helper mr,
> +  /usr/libexec/virt-aa-helper mr,

I suggest you use this instead here and in the rest of the patch series:

/usr/{lib,lib64,libexec}/libvirt/virt-aa-helper mr,

since it will let existing installs to continue to work.

>    /{usr/,}sbin/apparmor_parser Ux,
>  
>    /etc/apparmor.d/libvirt/* r,
> diff --git a/src/security/apparmor/usr.sbin.libvirtd b/src/security/apparmor/usr.sbin.libvirtd
> index 29f9936ad9..2089ba1b3e 100644
> --- a/src/security/apparmor/usr.sbin.libvirtd
> +++ b/src/security/apparmor/usr.sbin.libvirtd
> @@ -100,8 +100,8 @@ profile libvirtd /usr/sbin/libvirtd flags=(attach_disconnected) {
>    audit deny /sys/kernel/security/apparmor/.* rwxl,
>    /sys/kernel/security/apparmor/profiles r,
>    /usr/{lib,lib64}/libvirt/* PUxr,
> -  /usr/{lib,lib64}/libvirt/libvirt_parthelper ix,
> -  /usr/{lib,lib64}/libvirt/libvirt_iohelper ix,
> +  /usr/libexec/libvirt_parthelper ix,
> +  /usr/libexec/libvirt_iohelper ix,
>    /etc/libvirt/hooks/** rmix,
>    /etc/xen/scripts/** rmix,
>  
> -- 
> 2.24.1
> 
-- 
Jamie Strandboge             | http://www.canonical.com