[libvirt PATCH v3 3/4] ci: Use GitLab container registry

Andrea Bolognani abologna at redhat.com
Thu Jun 11 10:08:32 UTC 2020


On Thu, 2020-06-11 at 10:22 +0100, Daniel P. Berrangé wrote:
> On Wed, Jun 10, 2020 at 07:29:53PM +0200, Andrea Bolognani wrote:
> > But yeah, maybe I'm overthinking this. If the pipeline produces the
> > containers it consumes, then whether you label them as "latest"
> > or "master" or "a0sd90lv_k1" doesn't really make any difference,
> > because the next pipeline is going to build the containers again
> > before using them.
> 
> I just never much like the idea of things growing without bounds,
> even if someone else is paying for storage.

That's fair.

> > There is still one scenario in which reusing the same name could lead
> > to unwanted results, however, and that is when two or more pipelines
> > are running at the same time. Right now this is allowed, but by
> > using resource groups
> > 
> >   https://docs.gitlab.com/ee/ci/yaml/#resource_group
> > 
> > we should be able to prevent that from happening.
> 
> NB, running multiple pipelines in parallel is only a problem if those
> pipelines actually contain changes to the dockerfile recipes. Otherwise
> the rebuild of container images is essentially a no-op.

Yeah.

I posted a v4 which doesn't really do anything to prevent this
scenario from happening: if that turns our to be a real problem in
the future, we can introduce resource groups then.

-- 
Andrea Bolognani / Red Hat / Virtualization




More information about the libvir-list mailing list