[PATCH 00/16] Clean up of virJSONValueFree usage and few related refactors

Ján Tomko jtomko at redhat.com
Fri Dec 3 15:47:29 UTC 2021


On a Friday in 2021, Peter Krempa wrote:
>Peter Krempa (16):
>  qemu: hotplug: Use automatic freeing for virJSONValue
>  qemuDomainHotplugAddIOThread: Automatically free virJSONValue
>  qemuMonitorBlockdevCreate: Use double pointer instead of always
>    consuming '@props'
>  virLockDaemonClientPreExecRestart: Modernize JSON object construction
>  virLockDaemonPostExecRestart: Automatically free temporary variables
>  virLockDaemonPostExecRestart: Refactor cleanup
>  virLogDaemonPostExecRestart: Use automatic freeing for variables
>  virLogDaemonPostExecRestart: Refactor cleanup
>  virCHProcessUpdateInfo: Automatically free virJSONValue
>  tests/virnetdaemontest.c: testExecRestart: Automatically free
>    virJSONValue-s
>  qemuAgentGuestSync: Don't use goto for looping
>  qemuMonitorJSONGetCPUModelExpansion: Don't use goto for looping
>  qemuMonitorAddObject: Use g_clear_pointer for a free and reset
>    operation
>  qemuAgentIOProcessLine: refactor cleanup
>  qemu: agent: Automatically free virJSONValue-s
>  qemu: agent: Remove unneeded cleanup sections
>
> src/ch/ch_process.c          |   4 +-
> src/locking/lock_daemon.c    |  85 ++++------
> src/logging/log_daemon.c     |  42 ++---
> src/qemu/qemu_agent.c        | 304 ++++++++++++++++-------------------
> src/qemu/qemu_block.c        |   3 +-
> src/qemu/qemu_driver.c       |   3 +-
> src/qemu/qemu_hotplug.c      |  13 +-
> src/qemu/qemu_monitor.c      |  20 +--
> src/qemu/qemu_monitor.h      |   2 +-
> src/qemu/qemu_monitor_json.c |  79 +++++----
> src/qemu/qemu_monitor_json.h |   2 +-
> tests/virnetdaemontest.c     |   6 +-
> 12 files changed, 254 insertions(+), 309 deletions(-)

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211203/72829cf3/attachment-0001.sig>


More information about the libvir-list mailing list