[PATCH 1/3] virStreamInData: Allow callback to not rewind the stream

Martin Kletzander mkletzan at redhat.com
Wed Dec 8 20:57:28 UTC 2021


On Tue, Dec 07, 2021 at 04:34:40PM +0100, Michal Privoznik wrote:
>So far, virStreamInData() is effectively a wrapper over
>virFDStreamInData() which means it deals with files which can be rewind

*rewound

>(lseek()-ed) to whatever position we need. And in fact, that's what
>virFDStreamInData() does - it makes sure that the FD is left unchanged
>in terms of position in the file.  Skipping the hole happens soon after
>- in daemonStreamHandleRead() when virStreamSendHole() is called.
>
>But this is about to change. Soon we will have another implementation
>where we won't be dealing with FDs but virNetMessage queue and it will
>be handy to pop message at the beginning of the queue. Implement and
>document this new behavior.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20211208/c267331b/attachment-0001.sig>


More information about the libvir-list mailing list