[libvirt PATCH 04/17] util: move virStorageFileGetLVMKey to locking

[Peter Krempa]

On Mon, Dec 14, 2020 at 16:55:24 +0100, Pavel Hrdina wrote:
> The function doesn't take virStorageSource as argument and has nothing
> in common with virStorageSource or storage file.
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/libvirt_private.syms        |  1 -
>  src/locking/lock_driver_lockd.c | 66 ++++++++++++++++++++++++++++++++-
>  src/util/virstoragefile.c       | 62 -------------------------------
>  src/util/virstoragefile.h       |  2 -
>  4 files changed, 65 insertions(+), 66 deletions(-)

[...]

> +#ifdef LVS
> +static int virLockManagerGetLVMKey(const char *path,
> +                                   char **key)
> +{

Preferably convert the header to the modern function header style where
the function name starts on a new line after the type. (also in the
#else section)

> +    /*
> +     *  # lvs --noheadings --unbuffered --nosuffix --options "uuid" LVNAME

Reviewed-by: Peter Krempa <pkrempa at redhat.com>