[PATCH] schema: Fix TPM version rules

Daniel Henrique Barboza danielhb413 at gmail.com
Wed Jan 6 11:02:13 UTC 2021



On 1/6/21 7:53 AM, Michal Privoznik wrote:
> According to our parser (virDomainTPMDefParseXML()) the version
> is an optional attribute and independent of TPM backend type.
> Therefore, it's not a choice group, which is what our RNG schema
> suggests.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

>   docs/schemas/domaincommon.rng | 20 ++++++++------------
>   1 file changed, 8 insertions(+), 12 deletions(-)
> 
> diff --git a/docs/schemas/domaincommon.rng b/docs/schemas/domaincommon.rng
> index 712fb60562..86816e9b1d 100644
> --- a/docs/schemas/domaincommon.rng
> +++ b/docs/schemas/domaincommon.rng
> @@ -4776,18 +4776,14 @@
>             </optional>
>           </group>
>         </choice>
> -      <choice>
> -        <group>
> -          <optional>
> -            <attribute name="version">
> -              <choice>
> -                <value>1.2</value>
> -                <value>2.0</value>
> -              </choice>
> -           </attribute>
> -          </optional>
> -        </group>
> -      </choice>
> +      <optional>
> +        <attribute name="version">
> +          <choice>
> +            <value>1.2</value>
> +            <value>2.0</value>
> +          </choice>
> +       </attribute>
> +      </optional>
>       </element>
>     </define>
>   
> 




More information about the libvir-list mailing list