[PATCH] conf: rename virDomainCheckVirtioOptions

Daniel Henrique Barboza danielhb413 at gmail.com
Fri Jan 29 11:48:26 UTC 2021



On 1/29/21 8:39 AM, Boris Fiuczynski wrote:
> Rename virDomainCheckVirtioOptions into
> virDomainCheckVirtioOptionsAreAbent since it checks if all virtio

s/virDomainCheckVirtioOptionsAreAbent/virDomainCheckVirtioOptionsAreAbsent

> options are absent. The old name was very misleading.
> 
> Signed-off-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

Reviewed-by: Daniel Henrique Barboza <danielhb413 at gmail.com>

> ---
>   src/conf/domain_validate.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c
> index dd4c6e0fb3..a2f236c299 100644
> --- a/src/conf/domain_validate.c
> +++ b/src/conf/domain_validate.c
> @@ -227,7 +227,7 @@ virSecurityDeviceLabelDefValidate(virSecurityDeviceLabelDefPtr *seclabels,
>   
>   
>   static int
> -virDomainCheckVirtioOptions(virDomainVirtioOptionsPtr virtio)
> +virDomainCheckVirtioOptionsAreAbsent(virDomainVirtioOptionsPtr virtio)
>   {
>       if (!virtio)
>           return 0;
> @@ -316,7 +316,7 @@ virDomainDiskDefValidate(const virDomainDef *def,
>               return -1;
>           }
>   
> -        if (virDomainCheckVirtioOptions(disk->virtio) < 0)
> +        if (virDomainCheckVirtioOptionsAreAbsent(disk->virtio) < 0)
>               return -1;
>       }
>   
> @@ -1363,7 +1363,7 @@ virDomainNetDefValidate(const virDomainNetDef *net)
>       }
>   
>       if (!virDomainNetIsVirtioModel(net) &&
> -        virDomainCheckVirtioOptions(net->virtio) < 0) {
> +        virDomainCheckVirtioOptionsAreAbsent(net->virtio) < 0) {
>           return -1;
>       }
>   
> @@ -1513,7 +1513,7 @@ virDomainVsockDefValidate(const virDomainVsockDef *vsock)
>       }
>   
>       if (!virDomainVsockIsVirtioModel(vsock) &&
> -        virDomainCheckVirtioOptions(vsock->virtio) < 0)
> +        virDomainCheckVirtioOptionsAreAbsent(vsock->virtio) < 0)
>           return -1;
>   
>       return 0;
> 




More information about the libvir-list mailing list