[PATCH v1] meson: fix xenstore and xentoollog detection

Olaf Hering olaf at aepfle.de
Wed Jun 16 14:50:42 UTC 2021


Am Mon, 14 Jun 2021 14:38:19 +0100
schrieb Daniel P. Berrangé <berrange at redhat.com>:

> Based on this policy, it is clear that the Xen minimum should be
> 4.9 based on version information we can see for the distros.


Just to wrap up here:
The LIBXL_API_VERSION needs to stay at 4.5, because this is the only thing known by Xen 4.9.
As a result no code can be removed.
There are 4 LIBXL_HAVE_whatever knobs that appeared between Xen 4.6 and 4.9.
As a result only a few lines of #ifdef/#endif could be removed, no actual code.

So in my opinion it is not worth the effort, the patch for meson.build should be applied as it is.

I will leave it to Jim what to do with it.

Olaf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: Digitale Signatur von OpenPGP
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20210616/177b5f42/attachment-0001.sig>


More information about the libvir-list mailing list