[PATCH 13/17] virDomainAudioCommonParse: Fix parsing of 'format'

Peter Krempa pkrempa at redhat.com
Thu May 6 15:31:05 UTC 2021


Commit 38180f87f5b converted the code to use virXMLPropEnum unfaithfully
ommitting the check where 'format' must be non-zero when parsed from the
user.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 src/conf/domain_conf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
index ce0ffc60ef..d36ff536f4 100644
--- a/src/conf/domain_conf.c
+++ b/src/conf/domain_conf.c
@@ -13098,7 +13098,7 @@ virDomainAudioCommonParse(virDomainAudioIOCommon *def,

         if (virXMLPropEnum(settings, "format",
                            virDomainAudioFormatTypeFromString,
-                           VIR_XML_PROP_NONE, &def->format) < 0)
+                           VIR_XML_PROP_NONZERO, &def->format) < 0)
             return -1;
     }

-- 
2.30.2




More information about the libvir-list mailing list