[PATCH 1/5] ch_monitor: Stop leaking json value objects
William Douglas
william.douglas at intel.com
Fri Oct 1 18:12:33 UTC 2021
In virCHMonitorBuildKernelRelatedJson there are two cases of json
value objects being lost after the pointer being redefined. This
change removes the needless redefinition.
Signed-off-by: William Douglas <william.douglas at intel.com>
---
src/ch/ch_monitor.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/ch/ch_monitor.c b/src/ch/ch_monitor.c
index 5ed26a574f..a1430f0e65 100644
--- a/src/ch/ch_monitor.c
+++ b/src/ch/ch_monitor.c
@@ -121,7 +121,6 @@ virCHMonitorBuildKernelRelatedJson(virJSONValue *content, virDomainDef *vmdef)
_("Kernel image path in this domain is not defined"));
goto cleanup;
} else {
- kernel = virJSONValueNewObject();
if (virJSONValueObjectAppendString(kernel, "path", vmdef->os.kernel) < 0)
goto cleanup;
if (virJSONValueObjectAppend(content, "kernel", &kernel) < 0)
@@ -136,7 +135,6 @@ virCHMonitorBuildKernelRelatedJson(virJSONValue *content, virDomainDef *vmdef)
}
if (vmdef->os.initrd != NULL) {
- initramfs = virJSONValueNewObject();
if (virJSONValueObjectAppendString(initramfs, "path", vmdef->os.initrd) < 0)
goto cleanup;
if (virJSONValueObjectAppend(content, "initramfs", &initramfs) < 0)
--
2.33.0
More information about the libvir-list
mailing list