[libvirt PATCH 15/16] qemu: implement virtiofs hotplug

[Peter Krempa]

On Wed, Oct 06, 2021 at 09:15:21 +0200, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1897708
> 
> Signed-off-by: Ján Tomko <jtomko at redhat.com>
> ---
>  src/qemu/qemu_driver.c  |  9 +++-
>  src/qemu/qemu_hotplug.c | 96 +++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 104 insertions(+), 1 deletion(-)

Preliminary note. The tree fails to compile after this commit:

../../../libvirt/src/qemu/qemu_hotplug.c:3401:1: error: no previous prototype for ‘qemuDomainAttachFSDevice’ [-Werror=missing-prototypes]
 3401 | qemuDomainAttachFSDevice(virQEMUDriver *driver,
      | ^~~~~~~~~~~~~~~~~~~~~~~~
../../../libvirt/src/qemu/qemu_hotplug.c: In function ‘qemuDomainAttachFSDevice’:
../../../libvirt/src/qemu/qemu_hotplug.c:3426:9: error: implicit declaration of function ‘qemuAssignDeviceFSAlias’; did you mean ‘qemuAssignDeviceRNGAlias’? [-Werror=implicit-function-declaration]
 3426 |     if (qemuAssignDeviceFSAlias(vm->def, fs) < 0)
      |         ^~~~~~~~~~~~~~~~~~~~~~~
      |         qemuAssignDeviceRNGAlias
../../../libvirt/src/qemu/qemu_hotplug.c:3426:9: error: nested extern declaration of ‘qemuAssignDeviceFSAlias’ [-Werror=nested-externs]
../../../libvirt/src/qemu/qemu_hotplug.c:3432:20: error: implicit declaration of function ‘qemuBuildVHostUserFsDevStr’; did you mean ‘qemuBuildUSBHostdevDevStr’? [-Werror=implicit-function-declaration]
 3432 |     if (!(devstr = qemuBuildVHostUserFsDevStr(fs, vm->def, charAlias, priv)))
      |                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                    qemuBuildUSBHostdevDevStr
../../../libvirt/src/qemu/qemu_hotplug.c:3432:20: error: nested extern declaration of ‘qemuBuildVHostUserFsDevStr’ [-Werror=nested-externs]
../../../libvirt/src/qemu/qemu_hotplug.c:3432:18: error: assignment to ‘char *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
 3432 |     if (!(devstr = qemuBuildVHostUserFsDevStr(fs, vm->def, charAlias, priv)))
      |                  ^
cc1: all warnings being treated as errors