[PATCH v2] util: basic support for VFIO variant drivers

Michal Prívozník mprivozn at redhat.com
Tue Aug 23 15:21:27 UTC 2022


On 8/23/22 16:11, Laine Stump wrote:
> ping.
> 
> I have a different version of this patch where I do read the
> modules.alias file rather than just checking the name of the driver, but
> that also requires "double mocking" open() in the unit test, which
> wasn't working properly, and I'd rather not spend the time figuring it
> out if it's not going to be needed. (Alex prefers that version because
> it is more correct than just checking the name, and he's concerned that
> the new sysfs-based API may take longer than we're thinking to get into
> downstream distros, but the version in this patch does satisfy both
> Jason and Daniel's suggested implementations). Anyway, I can post the
> other patch if anyone is interested.

If you want I can help you with the mocking issue.
But for this patch - I don't have a strong opinion either way, sorry.
Maybe I lean more towards this solution, because it's simpler.

Michal



More information about the libvir-list mailing list