[PATCH 1/2] capabilityschemadata: Fix order of <features/> in caps-test2.xml

Michal Privoznik mprivozn at redhat.com
Wed Jul 20 06:36:28 UTC 2022


The guest <features/> is formatted in
virCapabilitiesFormatGuestFeatures() and the order in which
individual child elements are formatted is fixed, because the
function iterates over the virCapsGuestFeatureType enum
(possibly) formatting each member until _LAST is met.

Therefore, <cpuselection/> and <deviceboot/> can't ever be
formatted first. Move these elements to proper location.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
---
 tests/capabilityschemadata/caps-test2.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/capabilityschemadata/caps-test2.xml b/tests/capabilityschemadata/caps-test2.xml
index 125a322998..bf18010440 100644
--- a/tests/capabilityschemadata/caps-test2.xml
+++ b/tests/capabilityschemadata/caps-test2.xml
@@ -72,12 +72,12 @@
       </domain>
     </arch>
     <features>
-      <cpuselection/>
-      <deviceboot/>
       <pae/>
       <nonpae/>
       <acpi default='on' toggle='yes'/>
       <apic default='on' toggle='no'/>
+      <cpuselection/>
+      <deviceboot/>
     </features>
   </guest>
 
@@ -114,10 +114,10 @@
       </domain>
     </arch>
     <features>
-      <cpuselection/>
-      <deviceboot/>
       <acpi default='on' toggle='yes'/>
       <apic default='on' toggle='no'/>
+      <cpuselection/>
+      <deviceboot/>
     </features>
   </guest>
 
-- 
2.35.1



More information about the libvir-list mailing list