[PATCH 0/4] virnetdevbandwidthtest: Test QoS for OVS

[Martin Kletzander]

On Tue, Jun 28, 2022 at 04:17:31PM +0200, Michal Privoznik wrote:
>Cleanup virnetdevbandwidthtest and introduce new test cases.
>However, Martin suggested (after glancing over the last patch) that
>arguments could be stored in a file (just like qemuxml2argvtest does).
>I'm not against that, but QEMU cmd line args change more often than
>those of tc/ovs-vsctl. But if desired I can do the change (either as a
>follow up or in v2).
>

I, personally, do not need that, I just figured it could be nicer for
someone.

Anyway, good that you added the tests, I remember the units were not fun
to figure out with the inconsistencies wrt tc, so it's good we have it
in the tests too now.

>Michal Prívozník (4):
>  virnetdevbandwidthtest: Drop unnecessary brackets
>  virnetdevbandwidthtest: Drop unused testMinimalStruct
>  virnetdevbandwidthtest: Reformat TC cmd line
>  virnetdevbandwidthtest: Test QoS for OVS

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>

>
> tests/virnetdevbandwidthtest.c | 171 +++++++++++++++++++++------------
> 1 file changed, 109 insertions(+), 62 deletions(-)
>
>-- 
>2.35.1
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20220628/d9705256/attachment.sig>