[PATCH] docs: patches: Add a note about reviews and contacting developers

Peter Krempa pkrempa at redhat.com
Fri May 27 13:36:12 UTC 2022


Add a note outling best practices around review and responding to it.

Signed-off-by: Peter Krempa <pkrempa at redhat.com>
---
 docs/submitting-patches.rst | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/docs/submitting-patches.rst b/docs/submitting-patches.rst
index 7cb5c2e172..d6bc9b623c 100644
--- a/docs/submitting-patches.rst
+++ b/docs/submitting-patches.rst
@@ -89,3 +89,18 @@ Moreover, such patch needs to be prefixed correctly with
 ``--subject-prefix=PATCHv2`` appended to
 ``git send-email`` (substitute ``v2`` with the
 correct version if needed though).
+
+Reviews
+-------
+
+Please note that reviewing may take a lot of effort so be patient. Try to react
+to questions from reviewers. There's no need to acknowledge individual points
+before addressing them in next version. Make sure to address all of reviewers
+requests, or start a discussion if you don't agree with reviewers points.
+
+Feel free to respond to any flaw in any patch on the list, do not feel obliged
+to review the rest of the series in such case.
+
+If your patches don't get attention after some time (~week) feel free to
+remind us on list that your patches still need review. **Do not** contact
+individual maintainers directly to review your patches.
-- 
2.35.3



More information about the libvir-list mailing list