[PATCH 46/48] qemu: Assume QEMU_CAPS_DISK_WRITE_CACHE

Ján Tomko jtomko at redhat.com
Tue Nov 8 09:26:10 UTC 2022


On a Tuesday in 2022, Michal Privoznik wrote:
>Introduced in QEMU's commit of v2.7.0-rc0~32^2~5 the .write-cache
>attribute of virtio-blk dvice is always available for all QEMU
>versions we support (4.2.0, currently). Therefore, we can assume
>the capability is always set and thus doesn't need to be checked
>for.
>
>The change in some .args is justified, because the qemuxml2argvdatatest
>runs these test caseses with very minimalistic set of capabilities,
>that's nowhere near real life scenario.
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>---
> src/qemu/qemu_command.c                                  | 3 +--
> tests/qemuxml2argvdata/controller-order.args             | 2 +-
> tests/qemuxml2argvdata/video-device-pciaddr-default.args | 2 +-
> tests/qemuxml2argvdata/video-qxl-device-vgamem.args      | 2 +-
> tests/qemuxml2argvdata/video-qxl-device.args             | 2 +-
> tests/qemuxml2argvdata/video-qxl-sec-device-vgamem.args  | 2 +-
> tests/qemuxml2argvdata/video-qxl-sec-device.args         | 2 +-
> tests/qemuxml2argvdata/video-vga-device-vgamem.args      | 2 +-
> tests/qemuxml2argvdata/video-vga-device.args             | 2 +-
> tests/qemuxml2argvdata/video-virtio-gpu-device.args      | 2 +-
> tests/qemuxml2argvdata/video-virtio-gpu-sdl-gl.args      | 2 +-
> tests/qemuxml2argvdata/video-virtio-gpu-spice-gl.args    | 2 +-
> tests/qemuxml2argvdata/video-virtio-gpu-virgl.args       | 2 +-
> tests/qemuxml2argvdata/video-virtio-vga.args             | 2 +-
> 14 files changed, 14 insertions(+), 15 deletions(-)
>

Reviewed-by: Ján Tomko <jtomko at redhat.com>

Jano


More information about the libvir-list mailing list