[libvirt RFC 11/24] qemu_snapshot: extract children snapshot deletion to separate function
Pavel Hrdina
phrdina at redhat.com
Tue Oct 11 10:01:15 UTC 2022
On Thu, Sep 01, 2022 at 03:43:58PM +0200, Peter Krempa wrote:
> On Tue, Aug 23, 2022 at 18:32:14 +0200, Pavel Hrdina wrote:
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> > src/qemu/qemu_snapshot.c | 94 ++++++++++++++++++++++------------------
> > 1 file changed, 53 insertions(+), 41 deletions(-)
>
> Code change looks reasonable. I'd probably go for a C99-style init of
> the 'rem' struct.
This is only code movement so I would rather avoid doing any changes to
it. In addition there are other places like this so it would deserve
separate patches to address it.
> Please provide a commit message and function header documentation
> outlining what it's supposed to do.
Pavel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20221011/721b1d8d/attachment.sig>
More information about the libvir-list
mailing list