[libvirt RFC 17/24] qemu_snapshot: move metadata changes to qemuSnapshotDiscardMetadata

Peter Krempa pkrempa at redhat.com
Thu Sep 1 14:21:56 UTC 2022


On Tue, Aug 23, 2022 at 18:32:20 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_snapshot.c | 65 ++++++++++++++++++++--------------------
>  1 file changed, 32 insertions(+), 33 deletions(-)

Okay so this finally allows the function to be called
qemuSnapshotDiscardMetadata, but the way we got there was very
confusing.

At the very least you MUST write better commit messages for such changes
if the function is at the beginning doing something which doesn't make
sense.


More information about the libvir-list mailing list