[PATCH v2 3/9] qemu: Move <hostdev/> PCI backend setting into qemuDomainPrepareHostdev()

Martin Kletzander mkletzan at redhat.com
Mon Apr 24 11:09:22 UTC 2023


On Mon, Apr 24, 2023 at 12:41:42PM +0200, Michal Privoznik wrote:
>virsh command domxml-to-native failed with below error but start
>command succeed for same domain xml.
>
>  "internal error: invalid PCI passthrough type 'default'"
>
>If a <hostdev> PCI backend is not set in the XML, the supported
>one is then chosen in qemuHostdevPreparePCIDevicesCheckSupport().
>But this function is not called anywhere from
>qemuConnectDomainXMLToNative(). But qemuDomainPrepareHostdev()
>is. And it is also called from domain startup/hotplug code.
>Therefore, move the backend setting to the common path and drop
>qemuHostdevPreparePCIDevicesCheckSupport().
>
>Signed-off-by: Michal Privoznik <mprivozn at redhat.com>

Reviewed-by: Martin Kletzander <mkletzan at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230424/092187bc/attachment.sig>


More information about the libvir-list mailing list