[PATCH 11/11] qemuhotplugtest: Verify domain XML on UPDATE

[Kristina Hanicova]

On Fri, Apr 21, 2023 at 10:25 AM Michal Privoznik <mprivozn at redhat.com>
wrote:

> Just like we check the resulting domain XML after ATTACH and
> DETACH, we should do the same after UPDATE action. This is as
> simple as calling testQemuHotplugCheckResult() and providing
> missing XMLs. For those test cases where no change is done, we
> can just make the expected XML a symlink to the input XML.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/qemuhotplugtest.c                       |   9 +-
>  ...hotplug-disk-cdrom+disk-cdrom-nochange.xml |   1 +
>  .../qemuhotplug-disk-cdrom.xml                |  30 ++++-
>  ...graphics-spice+graphics-spice-nochange.xml |   1 +
>  ...graphics-spice-listen-network-password.xml |  71 +++++++++++
>  ...imeout+graphics-spice-timeout-nochange.xml |   1 +
>  ...imeout+graphics-spice-timeout-password.xml | 117 ++++++++++++++++++
>  .../qemuhotplug-graphics-spice-timeout.xml    |  50 ++++++--
>  .../qemuhotplug-graphics-spice.xml            |  41 ++++--
>  9 files changed, 295 insertions(+), 26 deletions(-)
>  create mode 120000
> tests/qemuhotplugtestdomains/qemuhotplug-disk-cdrom+disk-cdrom-nochange.xml
>  create mode 120000
> tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice+graphics-spice-nochange.xml
>  create mode 100644
> tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-listen-network+graphics-spice-listen-network-password.xml
>  create mode 120000
> tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-nochange.xml
>  create mode 100644
> tests/qemuhotplugtestdomains/qemuhotplug-graphics-spice-timeout+graphics-spice-timeout-password.xml
>
> Reviewed-by: Kristina Hanicova <khanicov at redhat.com>
thanks for your impact Michal,
Kristina
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20230424/1d2d1a8f/attachment.htm>