[libvirt PATCH 1/2] nodedev: refactor mdevctl thread functions

[Boris Fiuczynski]

On 7/6/23 9:44 PM, Jonathon Jongsma wrote:
> Factor out a new scheduleMdevctlUpdate() function so that we can re-use
> it from other places. Now that other events can make it necessary to
> re-query mdevctl for mdev updates, this function will be useful for
> coalescing multiple updates in quick succession into a single mdevctl
> query.
> 
> Also rename a couple functions. The names weren't very descriptive of
> their behavior. For example, the old scheduleMdevctlHandler() function
> didn't actually schedule anything, it just started a thread. So rename
> it to free up the 'schedule' name for the above refactored function.
> 
> Signed-off-by: Jonathon Jongsma <jjongsma at redhat.com>
> ---
>   src/node_device/node_device_udev.c | 37 ++++++++++++++++++++----------
>   1 file changed, 25 insertions(+), 12 deletions(-)
> 
> diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
> index fce4212728..9ba550dbc1 100644
> --- a/src/node_device/node_device_udev.c
> +++ b/src/node_device/node_device_udev.c
> @@ -2075,7 +2075,7 @@ udevPCITranslateInit(bool privileged G_GNUC_UNUSED)
>   
>   
>   static void
> -mdevctlHandlerThread(void *opaque G_GNUC_UNUSED)
> +mdevctlUpdateThreadFunc(void *opaque G_GNUC_UNUSED)
>   {
>       udevEventData *priv = driver->privateData;
>       VIR_LOCK_GUARD lock = virLockGuardLock(&priv->mdevctlLock);
> @@ -2085,8 +2085,9 @@ mdevctlHandlerThread(void *opaque G_GNUC_UNUSED)
>   }
>   
>   
> +
The above additional line should be removed.

>   static void
> -scheduleMdevctlHandler(int timer G_GNUC_UNUSED, void *opaque)
> +launchMdevctlUpdateThread(int timer G_GNUC_UNUSED, void *opaque)
>   {
>       udevEventData *priv = opaque;
>       virThread thread;
> @@ -2096,7 +2097,7 @@ scheduleMdevctlHandler(int timer G_GNUC_UNUSED, void *opaque)
>           priv->mdevctlTimeout = -1;
>       }
>   
> -    if (virThreadCreateFull(&thread, false, mdevctlHandlerThread,
> +    if (virThreadCreateFull(&thread, false, mdevctlUpdateThreadFunc,
>                               "mdevctl-thread", false, NULL) < 0) {
>           virReportSystemError(errno, "%s",
>                                _("failed to create mdevctl thread"));
> @@ -2192,6 +2193,26 @@ mdevctlEnableMonitor(udevEventData *priv)
>   }
<snip>

Beside the nit above
Reviewed-by: Boris Fiuczynski <fiuczy at linux.ibm.com>

-- 
Mit freundlichen Grüßen/Kind regards
    Boris Fiuczynski

IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Gregor Pillen
Geschäftsführung: David Faller
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294