[PATCH 2/2] libxl: Advertise support for VIR_MIGRATE_CHANGE_PROTECTION

Daniel P. Berrangé berrange at redhat.com
Thu Jul 13 12:58:22 UTC 2023


On Wed, Jul 12, 2023 at 03:26:15PM -0600, Jim Fehlig wrote:
> The libxl driver has basic support for VIR_MIGRATE_CHANGE_PROTECTION
> by starting and stopping modify jobs in the begin/confirm and prepare/finish
> phases of migration, but it doesn't advertise that support. This can result
> in unterminated jobs because the migration logic skips phases of migration
> when the VIR_MIGRATE_CHANGE_PROTECTION feature is absent. Ensure jobs are
> terminated properly by advertising support for VIR_MIGRATE_CHANGE_PROTECTION.
> 
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
>  src/libxl/libxl_driver.c    | 2 +-
>  src/libxl/libxl_migration.h | 3 ++-
>  2 files changed, 3 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange at redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|


More information about the libvir-list mailing list