[libvirt PATCH 0/8] rpm: Fix handling of systemd units

[Daniel P. Berrangé]

On Fri, Jul 14, 2023 at 04:39:34PM +0200, Andrea Bolognani wrote:
> Plus some extras I'm throwing in for free :)
> 
> To understand why these changes are needed, see the original bug
> report[1] as well as the discussion triggered by Martin's initial
> attempt at addressing it[2].
> 
> Getting this right is quite tricky, so in order to convince myself
> that I'm not just going to break everyone's deployment I've tested
> things fairly extensively.
> 
> In particular, I've verified that things work as expected when
> upgrading from libvirt 9.0.0 (e.g. pre-split) on AlmaLinux 8 when the
> initial configuration is
> 
>   * a default one (socket-activated monolithic daemon);
> 
>   * monolithic daemon with --listen;
> 
>   * modular daemons;
> 
>   * modular daemons with virtproxyd-tcp.socket enabled;
> 
> as well as when installing from scratch with
> 
>   * no particular configuration;
> 
>   * local systemd preset overrides that result in the modular daemons
>     being preferred to the monolithic one.
> 
> Everything seems to work fine, but further testing would certainly be
> more than welcome!

I don't have an objection to the conceptual approach.

My concern is about where the solution is applied and divergance from
Fedora guidelines.

The long term direction of Fedora / RPM has been to reduce the number
of scriptlets required to be explicitly listed in package specfiles, by
having RPM globally apply script logic for all content in certain given
directories. If we're using standard Fedora macros, then we'd not expect
to see problems if the macros get changed to adapt to new approaches,
but if we're going our own way all bets are off.

The current macros we're using are specified in the Fedora packaging
guidelines:

  https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_systemd

and their impl is provided by systemd upstream itself:

  https://github.com/systemd/systemd/blob/main/src/rpm/macros.systemd.in

The problems described do not appear to be things unique to libvirt.

IOW, I think the problem needs to be raised & addressed in context of
the Fedora and systemd communities, rather than having libvirt diverge
from normal Feora packaging practice.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|